if is not an archive, always copy
ClosedPublic

Authored by mart on Jan 13 2017, 12:54 PM.

Details

Summary

for wallpapers, some items can be an archive, some aren't
this may be true for other types of resources as well, so
make this more general. if the downloaded file is not an archive,
just copy it, instead of silently fail

Test Plan

different types of assets still install correctly, all wallpapers now install

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 10132.Jan 13 2017, 12:54 PM
mart retitled this revision from to if is not an archive, always copy.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 13 2017, 12:54 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
leinir accepted this revision.Jan 18 2017, 11:31 AM
leinir edited edge metadata.

Right. I think we can sensibly pick this. I would like a comment added, though, that future "don't simply install things" logic should go into the section above this one, rather than into the if statement there... but, other than that, yes, the logic itself is good, let's go for it :)

This revision is now accepted and ready to land.Jan 18 2017, 11:31 AM
mart updated this revision to Diff 10313.Jan 18 2017, 11:40 AM
mart edited edge metadata.
  • more comments
This revision was automatically updated to reflect the committed changes.