Avoid using API new in Qt 5.7. Plasma-workspace relies on Qt5.6
ClosedPublic
Actions

Authored by davidedmundson on Jan 12 2017, 12:00 PM.

Details

Reviewers

Group Reviewers

Commits

Test Plan

Tested menu is still in the same place

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson retitled this revision from to Avoid using API new in Qt 5.7. Plasma-workspace relies on Qt5.6.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

I think we should rather had (may be late, unfortunately) raised the qt requirements in cmake, as the decision to depend on 5.7 was already taken

too late to officially raise the dep, to be done after the branch

This revision is now accepted and ready to land.Jan 12 2017, 12:20 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/appmenu/lib/appmenuapplet.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10090	fcdf097		Jan 12 2017, 12:00 PM	★	★
Diff 2	10091	fcdf097	R120:6f90f8cf8095d597663986ac6ac8f54137582d0a	Jan 12 2017, 12:00 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f3900db3f60b	39e23baad4a3	fcdf0970109c	David Edmundson	Avoid using API new in Qt 5.7. Plasma-workspace apparently relies on Qt5.6	Jan 12 2017, 11:59 AM