Add support for skip close animation to OnScreenMessage
ClosedPublic
Actions

Authored by graesslin on Jan 11 2017, 7:16 PM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:d38bce776fa2: Add support for skip close animation to OnScreenMessage

Summary

This change adds support for marking the OnScreenMessage as it should
skip close animation. The screenshot effect is adjusted to use the
on screen message instead of the custom effect frame.

Test Plan

Message window is not captured when taking screenshot

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 10069.Jan 11 2017, 7:16 PM

graesslin retitled this revision from to Add support for skip close animation to OnScreenMessage.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJan 11 2017, 7:16 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependency: D4089: Add support for skipCloseAnimation for internal windows.Jan 11 2017, 7:16 PM

ping, important for Plasma 5.9

davidedmundson accepted this revision.Jan 24 2017, 9:41 PM

davidedmundson added a reviewer: davidedmundson.

This revision is now accepted and ready to land.Jan 24 2017, 9:41 PM

Closed by commit R108:d38bce776fa2: Add support for skip close animation to OnScreenMessage (authored by graesslin). · Explain WhyJan 25 2017, 12:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/mock_effectshandler.h (2 lines)
M			effects.h (2 lines)
M			effects.cpp (8 lines)
M			effects/screenshot/screenshot.h (1 line)
M			effects/screenshot/screenshot.cpp (24 lines)
M			libkwineffects/kwineffects.h (16 lines)
M			onscreennotification.h (1 line)
M			onscreennotification.cpp (7 lines)
M			osd.h (7 lines)
M			osd.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10069	38c394a		Jan 11 2017, 7:16 PM	★	★
Diff 2	10537	31405ae	R108:d38bce776fa2dda6288474c0484c8113fb99e5ef	Jan 25 2017, 12:54 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0dbb53616f9d	a781ef13fd2d	38c394ae9213	Martin Gräßlin	Add support for skip close animation to OnScreenMessage (Show More…)	Jan 11 2017, 7:14 PM

	Status	Author	Revision
	Closed	graesslin	D4091 Add support for skip close animation to OnScreenMessage
	Closed	graesslin	D4089 Add support for skipCloseAnimation for internal windows