[Notes Applet] Reduce switch size and hide controls if too small
ClosedPublic

Authored by broulik on Jan 10 2017, 2:25 PM.

Details

Summary

When resizing the applet smaller it can be unexpected that it suddenly switches to compact representation, especially when formatting controls (Bold, etc) aren't shown.
Reduce the switch size to be quite small and just hide the formatting controls if the applet becomes too small. Nowadays you can toggle formatting with Ctrl keys (Ctrl+B for Bold, etc) anyway.
Also, move the formatting controls into their own Row so we can hide them as a single unit.

Test Plan

I can now resize the applet pretty small and still see its contents without the controls leaking outside.

In panel default size for popup is still ok and the applet icon shows fine.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9977.Jan 10 2017, 2:25 PM
broulik retitled this revision from to [Notes Applet] Reduce switch size and hide controls if too small.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R114 Plasma Addons.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 10 2017, 2:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Jan 10 2017, 2:31 PM
mart accepted this revision.Jan 10 2017, 3:22 PM
mart added a reviewer: mart.
mart added a subscriber: mart.

ok for me, tough i think it can still be reworked a bit to clean it up generally

applets/notes/package/contents/ui/main.qml
235

could instead those buttons be in a Row, and control the visibility of the whole row by its width rather than computing by hand the width of all buttons?

This revision is now accepted and ready to land.Jan 10 2017, 3:22 PM
broulik updated this revision to Diff 9986.Jan 10 2017, 3:39 PM
broulik updated this object.
broulik edited edge metadata.
broulik changed the repository for this revision from R114 Plasma Addons to R120 Plasma Workspace.
  • Move format controls (Bold, Italic, Underline, Strikethrough) into their own Row so we can hide them as a single unit
This revision was automatically updated to reflect the committed changes.