Differential D4064

Sheets: Improve formatting of scientific numbers
ClosedPublic
Actions

Authored by danders on Jan 10 2017, 12:09 PM.

Details

Reviewers
mecir
Commits
R8:f1f329cadf24: Sheets: Improve formatting of scientific numbers
Summary

Handle precision and min-exponent-digits
Add unit tests

TODO: Add min-exponent-digits to the cell formatting dialog

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders updated this revision to Diff 9966.Jan 10 2017, 12:09 PM
danders retitled this revision from to Sheets: Improve formatting of scientific numbers.
danders updated this object.
danders edited the test plan for this revision. (Show Details)
danders added a reviewer: mecir.
Restricted Application added projects: KEXI, Calligra: 3.0. · View Herald TranscriptJan 10 2017, 12:09 PM
staniek added a subscriber: staniek.Jan 10 2017, 2:06 PM

@danders Why is Kexi tag included in this review?

danders added a comment.Jan 11 2017, 8:08 AM
In D4064#75985, @staniek wrote:

@danders Why is Kexi tag included in this review?

Don't know, you seem to pop up everywhere :)
I only added mecir, could it have something to do with this?

Restricted Application added projects: Kexi, Calligra: 3.0. · View Herald Transcript

mecir accepted this revision.Jan 14 2017, 10:19 AM
mecir edited edge metadata.

Looks good. And yeah, we should use QLocale eventually, but for now it doesn't support what we need re localisation.

This revision is now accepted and ready to land.Jan 14 2017, 10:19 AM
Closed by commit R8:f1f329cadf24: Sheets: Improve formatting of scientific numbers (authored by danders). · Explain WhyJan 24 2017, 10:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10484

View Options

sheets/ValueFormatter.cpp

Loading...
View Options

sheets/commands/StyleCommand.h

Loading...
View Options

sheets/dialogs/LayoutDialog.cpp

Loading...
View Options

sheets/tests/TestValueFormatter.cpp

Loading...