Differential D4024

[System Tray] Trigger context menu on press
ClosedPublic
Actions

Authored by broulik on Jan 8 2017, 5:23 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:b9af99140365: [System Tray] Trigger context menu on press
R120:b9af99140365: [System Tray] Trigger context menu on press
Summary

Everywhere else context menus are triggered on mouse *press* not on release.

Test Plan

Right click opens menu immediately while button is still pressed
For left click activation I need to press and release

Expanding and collapsing applets still works
Triggering status notifiers still works
Mouse wheel still works

Tooltip properly hides in both cases

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9870.Jan 8 2017, 5:23 PM
broulik retitled this revision from to [System Tray] Trigger context menu on press.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 8 2017, 5:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 10 2017, 3:47 PM
mart added a reviewer: mart.
mart added a subscriber: mart.
mart added inline comments.
applets/systemtray/package/contents/ui/items/AbstractItem.qml
103

is abstractItem.hideToolTip() really not needed anymore?

This revision is now accepted and ready to land.Jan 10 2017, 3:47 PM
broulik added inline comments.Jan 10 2017, 3:49 PM
applets/systemtray/package/contents/ui/items/AbstractItem.qml
103

onPressed hides the tooltip and onPressed is triggered before click anyway

Closed by commit R120:b9af99140365: [System Tray] Trigger context menu on press (authored by broulik). · Explain WhyJan 11 2017, 9:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10025

View Options

applets/systemtray/package/contents/ui/items/AbstractItem.qml

Loading...
View Options

applets/systemtray/package/contents/ui/items/PlasmoidItem.qml

Loading...
View Options

applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

Loading...