Fix mini map for HiDPI settings
ClosedPublic

Authored by cullmann on Jan 8 2017, 2:33 PM.

Details

Summary

Fix mini map for HiDPI settings

e.g. compare kwrite with and without this patch after setting

export QT_SCALE_FACTOR=2

Test Plan

Run without

export QT_SCALE_FACTOR=2

and run with

export QT_SCALE_FACTOR=2

> looks better, more like pixels not blocks

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cullmann updated this revision to Diff 9854.Jan 8 2017, 2:33 PM
cullmann retitled this revision from to Fix mini map for HiDPI settings.
cullmann updated this object.
cullmann edited the test plan for this revision. (Show Details)
cullmann added reviewers: Kate, dhaumann.
cullmann set the repository for this revision to R39 KTextEditor.
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 8 2017, 2:33 PM
Restricted Application added subscribers: Frameworks, kwrite-devel. · View Herald Transcript
dhaumann accepted this revision.Jan 8 2017, 3:39 PM
dhaumann edited edge metadata.

In general ok - but sure whether we need qCeil() to round sizes up, but if it looks ok, it's probably fine to commit.

src/view/kateviewhelpers.cpp
479 ↗(On Diff #9854)

Do we maybe need a qCeil here?

This revision is now accepted and ready to land.Jan 8 2017, 3:39 PM
cullmann added inline comments.Jan 9 2017, 5:15 AM
src/view/kateviewhelpers.cpp
479 ↗(On Diff #9854)

I think Qt internally doesn't round up either.

This revision was automatically updated to reflect the committed changes.