Reduces the amount of unneccessary layouting done.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R242:4b55493568b1: [Dialog] Use setPosition / setSize instead of setting everything individually
Tests pass, dialogs and tooltips looking good.
It feels like kickoff opens quicker on a fresh start because tab bar no longer layouts crap (sometimes you could briefly see all buttons cramped together for a frame)
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The idea that it will change whether you see the tab bar resize isn't true.
Setwidth and setHeight are done in sequence. There's no way you can get a repaint in between them. (Unless some code has an animation somewhere?)
However this is still better.