[Dialog] Use setPosition / setSize instead of setting everything individually
ClosedPublic

Authored by broulik on Jan 8 2017, 10:53 AM.

Details

Summary

Reduces the amount of unneccessary layouting done.

Test Plan

Tests pass, dialogs and tooltips looking good.

It feels like kickoff opens quicker on a fresh start because tab bar no longer layouts crap (sometimes you could briefly see all buttons cramped together for a frame)

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9836.Jan 8 2017, 10:53 AM
broulik retitled this revision from to [Dialog] Use setPosition / setSize instead of setting everything individually.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 8 2017, 10:53 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

The idea that it will change whether you see the tab bar resize isn't true.

Setwidth and setHeight are done in sequence. There's no way you can get a repaint in between them. (Unless some code has an animation somewhere?)

However this is still better.

davidedmundson accepted this revision.Jan 8 2017, 1:49 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 8 2017, 1:49 PM
This revision was automatically updated to reflect the committed changes.