Differential D4000

Properly kill AddToArchive jobs
ClosedPublic
Actions

Authored by elvisangelaccio on Jan 7 2017, 12:25 PM.

Details

Reviewers
rthomsen
Commits
R36:e777831fe4a7: Properly kill AddToArchive jobs
Summary

Both AddToArchive and CreateJob are wrapper jobs, they need to implement
doKill() and call kill() on the actual jobs that are doing the work.

BUG: 374433
FIXED-IN: 16.12.1

Test Plan

Compress a big folder from Dolphin, stop job from system tray. Crash is gone.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 9816.Jan 7 2017, 12:25 PM
elvisangelaccio retitled this revision from to Properly kill AddToArchive jobs.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptJan 7 2017, 12:25 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Jan 8 2017, 1:19 PM
rthomsen edited edge metadata.

Fixes the bug for me :)

This revision is now accepted and ready to land.Jan 8 2017, 1:19 PM
Closed by commit R36:e777831fe4a7: Properly kill AddToArchive jobs (authored by elvisangelaccio). · Explain WhyJan 8 2017, 4:18 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:e777831fe4a7: Properly kill AddToArchive jobs.

Revision Contents
Changeset List

Diff 9865

View Options

kerfuffle/addtoarchive.h

Loading...
View Options

kerfuffle/addtoarchive.cpp

Loading...
View Options

kerfuffle/jobs.h

Loading...
View Options

kerfuffle/jobs.cpp

Loading...
View Options

plugins/libarchive/libarchiveplugin.cpp

Loading...