Differential D3973

wallpapers/image: Use QImageReader in ImageSizeFinder::run()
ClosedPublic
Actions

Authored by fredrik on Jan 4 2017, 9:37 PM.

Details

Reviewers
davidedmundson
broulik
Group Reviewers
Plasma
Commits
R120:ee245780f236: wallpapers/image: Use QImageReader in ImageSizeFinder::run()
R871:ee245780f236: wallpapers/image: Use QImageReader in ImageSizeFinder::run()
Summary

There is no need to decode the whole image and load it into memory
when we are only interested in the dimensions.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fredrik updated this revision to Diff 9731.Jan 4 2017, 9:37 PM
fredrik retitled this revision from to wallpapers/image: Use QImageReader in ImageSizeFinder::run().
fredrik updated this object.
fredrik edited the test plan for this revision. (Show Details)
fredrik added a reviewer: Plasma.
fredrik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2017, 9:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jan 4 2017, 9:42 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

thanks

This revision is now accepted and ready to land.Jan 4 2017, 9:42 PM
broulik accepted this revision.Jan 4 2017, 9:43 PM
broulik added a reviewer: broulik.
Closed by commit R120:ee245780f236: wallpapers/image: Use QImageReader in ImageSizeFinder::run() (authored by fredrik). · Explain WhyJan 5 2017, 12:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9735

View Options

wallpapers/image/backgroundlistmodel.cpp

Loading...