Fade out OnScreenNotification when moving with the mouse over it
ClosedPublic
Actions

Authored by graesslin on Jan 4 2017, 5:04 PM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:80adfd0274af: Fade out OnScreenNotification when moving with the mouse over it

Summary

This change triggers a fade out animation when the mouse is moved over
the OnScreenNotification, thus revealing the windows underneath. When
moving the mouse out of the OnScreenNotification it gets faded in again.

This is useful for various cases, e.g. when picking a color and the pixel
one wants to pick is underneath the notification, or when trying to kill
a window...

Test Plan

Manual testing in nested setup

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 9717.Jan 4 2017, 5:04 PM

graesslin retitled this revision from to Fade out OnScreenNotification when moving with the mouse over it.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJan 4 2017, 5:04 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added dependencies: D3928: Sync opacity from an internal QWindow to its ShellClient, D3963: Fix syncing of geometry to internal window when using ::move.Jan 4 2017, 5:05 PM

davidedmundson accepted this revision.Jan 4 2017, 5:49 PM

davidedmundson added a reviewer: davidedmundson.

davidedmundson added a subscriber: davidedmundson.

davidedmundson added inline comments.

onscreennotification.cpp
209	you could have put the animation in the constructor normally and then do setTargetObject once you make the window

This revision is now accepted and ready to land.Jan 4 2017, 5:49 PM

Closed by commit R108:80adfd0274af: Fade out OnScreenNotification when moving with the mouse over it (authored by graesslin). · Explain WhyJan 5 2017, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/CMakeLists.txt (2 lines)
M			autotests/onscreennotificationtest.cpp (18 lines)
M			onscreennotification.h (11 lines)
M			onscreennotification.cpp (69 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9717	6a78bd4		Jan 4 2017, 5:04 PM	★	★
Diff 2	9765	6a78bd4	R108:80adfd0274afd95e1f7589bf2ae444f40e408eea	Jan 4 2017, 5:04 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
13eaf317ab80	11d5e95a0a13	6a78bd45fea3	Martin Gräßlin	Fade out OnScreenNotification when moving with the mouse over it (Show More…)	Jan 4 2017, 5:01 PM

Status	Author	Revision
Closed	graesslin	D3964 Fade out OnScreenNotification when moving with the mouse over it
Closed	graesslin	D3963 Fix syncing of geometry to internal window when using ::move
Closed	graesslin	D3928 Sync opacity from an internal QWindow to its ShellClient