Differential D3935

In doubt use URL scheme for place
ClosedPublic
Actions

Authored by broulik on Jan 3 2017, 1:23 PM.

Details

Reviewers
emmanuelp
Group Reviewers
Dolphin
Commits
R318:215bed085b99: In doubt use URL scheme for place
Summary

If we neither have a filename nor a host, we might be in a foo:/ URL, use the scheme then.

Test Plan

Navigate to desktop:/ now click add to places. Before it would add a place named "I18N_EMPTY_ARGUMENT", now I get a "desktop" place.

Dunno if the user can actually get here through GUI or whether desktop:/ is reserved for internal use and we always use ~/Desktop file URL instead

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9656.Jan 3 2017, 1:23 PM
broulik retitled this revision from to In doubt use URL scheme for place.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Dolphin.
broulik set the repository for this revision to R318 Dolphin.
emmanuelp accepted this revision.Jan 14 2017, 11:08 AM
emmanuelp added a reviewer: emmanuelp.
This revision is now accepted and ready to land.Jan 14 2017, 11:08 AM
Closed by commit R318:215bed085b99: In doubt use URL scheme for place (authored by broulik). · Explain WhyJan 16 2017, 2:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dolphinviewcontainer.cpp (3 lines)

Diff 10239

View Options

src/dolphinviewcontainer.cpp

Loading...