Don't check 'Extraction into subfolder' with single-file archives
ClosedPublic
Actions

Authored by elvisangelaccio on Dec 30 2016, 3:59 PM.

Details

Reviewers

Commits

R36:a91c09d0d202: Don't check 'Extraction into subfolder' with single-file archives

Summary

The ExtractionDialog only needs to know if it should enable the 'Extraction
into subfolder' groupbox, not why. We rename setIsSingleFolder() to
setExtractToSubfolder() and we call it with
archive->hasMultipleTopLevelEntries() as argument.
This fixes the regression with single-file archives.

CCBUG: 374253

Test Plan

Open a single-file archive, open the extraction dialog. The 'Extraction into
subfolder' groupbox is now unchecked.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 9497.Dec 30 2016, 3:59 PM

elvisangelaccio retitled this revision from to Don't check 'Extraction into subfolder' with single-file archives.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: rthomsen.

Restricted Application added a project: Ark. · View Herald TranscriptDec 30 2016, 3:59 PM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

What about quick extractions? We should probably do the same there. I'm not sure about batch-extractions, instead: "autodetect folder" does not necessarily mean "force subfolder"...

Ping?

In D3873#72501, @elvisangelaccio wrote:

What about quick extractions? We should probably do the same there. I'm not sure about batch-extractions, instead: "autodetect folder" does not necessarily mean "force subfolder"...

But the ark docbook says:

Extract Archive Here, Autodetect Subfolder creates a subfolder in the folder with the archive and extracts the folders and files into it.

so ok, let's not change this behavior.

Tested and it fixes the bug. And yes, quick-extractions should behave the same way.

This revision is now accepted and ready to land.Mar 5 2017, 5:52 PM

Closed by commit R36:a91c09d0d202: Don't check 'Extraction into subfolder' with single-file archives (authored by elvisangelaccio). · Explain WhyMar 5 2017, 6:15 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:a91c09d0d202: Don't check 'Extraction into subfolder' with single-file archives.

Revision Contents
Changeset List

			Path	Packages
M			app/batchextract.cpp (2 lines)
M			kerfuffle/extractiondialog.h (2 lines)
M			kerfuffle/extractiondialog.cpp (6 lines)
M			part/part.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9497	b887900		Dec 30 2016, 3:59 PM	★	★
Diff 2	12194	69a83eb	R36:a91c09d0d202fa5d8788ef3bdb85d6e7f75c061f	Mar 5 2017, 6:13 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8d459bd44f9b	e912ab0b7299	b8879008fd15	Elvis Angelaccio	Don't check 'Extraction into subfolder' with single-file archives (Show More…)	Dec 30 2016, 3:45 PM