Reduce API exposed through dbus

Authored by apol on Dec 30 2016, 3:41 PM.



Don't use QDBusConnection::ExportAllContents
No need to make connect and receivedPackage public slots (they're are the
parent's already)

Fixes T4975

Test Plan

Rough manual test

Diff Detail

R224 KDE Connect
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 9494.Dec 30 2016, 3:41 PM
apol retitled this revision from to Reduce API exposed through dbus.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added a reviewer: albertvaka.
albertvaka added inline comments.Dec 31 2016, 2:51 PM

Why Properties instead of ExportScriptableInvokables? ring() should be able callable through dbus.


What do you think about exposing always both things (properties and scriptableinvokables), even on plugins where there are no properties or no dbus slots? This way if we add any it will already work. Also, this is a line I tend to copy-paste when writing a new plugin, so it's better if it "just works" wherever I copy it from.

apol updated this revision to Diff 9989.Jan 10 2017, 4:08 PM

Generalize dbus registration

Instead of explicitly registering every plugin, register all plugins
with a dbusPath method.

albertvaka accepted this revision.Jan 10 2017, 5:24 PM
albertvaka edited edge metadata.
This revision is now accepted and ready to land.Jan 10 2017, 5:24 PM
This revision was automatically updated to reflect the committed changes.