Differential D3847

SWT/Eclipse toolbar fix
ClosedPublic
Actions

Authored by jsalatas on Dec 29 2016, 7:30 AM.

Details

Reviewers
mart
Group Reviewers
Breeze
Commits
R98:85fd0772a125: SWT/Eclipse toolbar fix
Summary

In eclipse running with SWT gtk2 the buttons in the toolbar don't behave as they should:

  1. There is no highlighting when hovering
  2. For toggle buttons there is no active/inactive indication.
Test Plan

Tested in KDE Neon User as of December, 28th

Before

After

Besides these two issues the patch seems to (unintentionally) improve some real-estates (see for example secondary toolbar buttons in Package Explorer and Outline views).

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Lint Skipped
Unit
Unit Tests Skipped
jsalatas updated this revision to Diff 9436.Dec 29 2016, 7:30 AM
jsalatas retitled this revision from to SWT/Eclipse toolbar fix.
jsalatas updated this object.
jsalatas edited the test plan for this revision. (Show Details)
jsalatas added a reviewer: Breeze.
jsalatas set the repository for this revision to R98 Breeze for Gtk.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 29 2016, 7:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Dec 30 2016, 9:56 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Dec 30 2016, 9:56 AM
Closed by commit R98:85fd0772a125: SWT/Eclipse toolbar fix (authored by jsalatas). · Explain WhyDec 30 2016, 10:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9436

View Options

Breeze-dark-gtk/gtk-2.0/widgets/styles

Loading...
View Options

Breeze-gtk/gtk-2.0/widgets/styles

Loading...