[Calendar] Optimize day delegate
AbandonedPublic

Authored by broulik on Dec 28 2016, 2:48 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Summary
  • Use a single global MouseArea and turn delegate into an Item
  • Use a single Rectangle for both "today" and "highlighted" state
  • Add font.pointSize: -1 workaround in the other labels to avoid runtime warnings
Test Plan
  • Hovering and selecting items still works, updates agenda as needed, also "has appointment" overlay still works
  • Switching between months updates the highlight - you can see a brief transition from gray to blue and then invisible when you move between the current month and others as the single Rectangle will transition from gray to blue in response to becoming "not today" and opacity 1 to 0 in response to being no longer selected, not too terrible, though.
  • Pinch to zoom still works
  • didn't notice stray highlight when closing popup with mouse still hovering

Unfortunately did not result in a noticeable speedup of first invocation

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 9419.Dec 28 2016, 2:48 PM
broulik retitled this revision from to [Calendar] Optimize day delegate.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added a project: Plasma. · View Herald TranscriptDec 28 2016, 2:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Dec 29 2016, 1:26 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Dec 29 2016, 1:26 PM
broulik abandoned this revision.May 25 2018, 8:41 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 25 2018, 8:41 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript