Differential D3823

[Lock Screen] Use QtRendering for Clock
ClosedPublic
Actions

Authored by broulik on Dec 27 2016, 5:57 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:23364f7f4913: [Lock Screen] Use QtRendering for Clock
R120:23364f7f4913: [Lock Screen] Use QtRendering for Clock
Summary

NativeRendering often utterly breaks at large font sizes. We had this in the previous lock screen design.

Test Plan

I now have a good-looking clock font again, not 2 meter letter spacing

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9396.Dec 27 2016, 5:57 PM
broulik retitled this revision from to [Lock Screen] Use QtRendering for Clock.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 27 2016, 5:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.Dec 27 2016, 11:08 PM

wasn't it just large sizes with devicePixelRatio running?

mart accepted this revision.Dec 28 2016, 11:15 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

I think it's correct.
anyways, you don't need hinting when the font is so huge

This revision is now accepted and ready to land.Dec 28 2016, 11:15 AM
Closed by commit R120:23364f7f4913: [Lock Screen] Use QtRendering for Clock (authored by broulik). · Explain WhyDec 30 2016, 9:07 PM
This revision was automatically updated to reflect the committed changes.
broulik added a comment.Jan 23 2017, 11:48 AM

FTR the Qt bug that caused this is fixed in 5.8: https://bugreports.qt.io/browse/QTBUG-55856

Revision Contents
Changeset List

Diff 9520

View Options

lookandfeel/contents/components/Clock.qml

Loading...