Differential D3739

Correctly initialise and compare pa_cvolume structs
ClosedPublic
Actions

Authored by davidedmundson on Dec 19 2016, 6:22 PM.

Details

Reviewers
drosca
Group Reviewers
Plasma
Commits
R115:fbab032d122e: Correctly initialise and compare pa_cvolume structs
R994:fbab032d122e: Correctly initialise and compare pa_cvolume structs
Summary

Previously m_volume was uninitialised, resulting in a comparison on
garbage data when first run.
By using the proper pulse audio methods we can make sure to initialise
the variable and use a faster compare than memcmp.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 9175.Dec 19 2016, 6:22 PM
davidedmundson retitled this revision from to Correctly initialise and compare pa_cvolume structs.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptDec 19 2016, 6:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
drosca accepted this revision.Dec 19 2016, 9:33 PM
drosca added a reviewer: drosca.
This revision is now accepted and ready to land.Dec 19 2016, 9:33 PM
Closed by commit R115:fbab032d122e: Correctly initialise and compare pa_cvolume structs (authored by davidedmundson). · Explain WhyDec 19 2016, 10:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/volumeobject.h (2 lines)
Msrc/volumeobject.cpp (1 line)

Diff 9175

View Options

src/volumeobject.h

Loading...
View Options

src/volumeobject.cpp

Loading...