Make sure pages are destroying when popping
ClosedPublic
Actions

Authored by apol on Dec 18 2016, 7:36 PM.

Details

Reviewers

mart

Group Reviewers

Kirigami

Commits

Summary

For some reason, reparenting the page is not enough. Also fixes the test which
was not working properly.

Test Plan

Now the tests pass

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol retitled this revision from to Make sure pages are destroying when popping.

apol updated this object.

apol edited the test plan for this revision. (Show Details)

apol added reviewers: Kirigami, mart.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart edited edge metadata.

This revision is now accepted and ready to land.Dec 19 2016, 9:39 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/tst_pagerow.qml (16 lines)
M			src/controls/PageRow.qml (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9145	78e9385		Dec 18 2016, 7:36 PM	★	★
Diff 2	9158	1e3a630	R169:d199731bd33dae809f42785cbb123e305cab8671	Dec 19 2016, 11:49 AM	★	★