Differential D3716

Introduce settings page to configure plugins
ClosedPublic
Actions

Authored by elvisangelaccio on Dec 17 2016, 2:59 PM.

Details

Reviewers
rthomsen
Maniphest Tasks
T1984: Plugins page in Settings dialog
Summary

New page in the settings dialog where the user can enable/disable plugins. The page contains a QTreeWidget which is not supported by KConfigDialog out of the box, so some glue-code was necessary to properly handle the Apply/Default buttons. ArkSettings stores a list of disabled plugins (by default, all plugins are enabled).

Things missing:

  • Proper metadata in the json files (Name/Description data in the model comes from there)
  • Proper icon the dialog
Test Plan

Enable/disable some plugins, make sure the Default/Apply buttons work as expected.

Diff Detail

Repository
R36 Ark
Lint
Lint Skipped
Unit
Unit Tests Skipped
elvisangelaccio updated this revision to Diff 9121.Dec 17 2016, 2:59 PM
elvisangelaccio retitled this revision from to Introduce settings page to configure plugins.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to R36 Ark.
Restricted Application added a project: Ark. · View Herald TranscriptDec 17 2016, 2:59 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
elvisangelaccio added a subscriber: andreaska.Dec 17 2016, 3:02 PM

@andreaska Why the preferences-plugin icon is colored at this size (see screenshot)?

elvisangelaccio updated this revision to Diff 9126.Dec 17 2016, 3:38 PM
elvisangelaccio removed R36 Ark as the repository for this revision.

Fixed icon

@andreaska Forget my previous question :)

elvisangelaccio updated this revision to Diff 9127.Dec 17 2016, 3:48 PM
elvisangelaccio set the repository for this revision to R36 Ark.

We can just use Qt::UserRole (no reason to use Qt::UserRole + 1).

rthomsen accepted this revision.Dec 17 2016, 5:14 PM
rthomsen edited edge metadata.
rthomsen added inline comments.
kerfuffle/ark.kcfg
50

disabledPlugins -> DisabledPlugins, same below...

This revision is now accepted and ready to land.Dec 17 2016, 5:14 PM
rthomsen requested changes to this revision.Dec 17 2016, 5:37 PM
rthomsen edited edge metadata.

There is a bug. Steps to reproduce:

  1. Open Ark and disable any three plugins.
  2. Re-open Ark->the three disabled plugins are still disabled.
  3. Enable one of them.
  4. Close and re-open Ark->All three are enabled now.
This revision now requires changes to proceed.Dec 17 2016, 5:37 PM
elvisangelaccio updated this revision to Diff 9128.Dec 17 2016, 6:09 PM
elvisangelaccio edited edge metadata.

Fixed initialization bug

elvisangelaccio updated this revision to Diff 9129.Dec 17 2016, 6:38 PM
elvisangelaccio edited edge metadata.

Disable item if plugin is invalid and add explanation in a tooltip

rthomsen added inline comments.Dec 17 2016, 6:58 PM
kerfuffle/pluginsettingspage.cpp
57

executables -> required executables
Checks -> Check

elvisangelaccio updated this revision to Diff 9131.Dec 17 2016, 9:47 PM
  • Better tooltip text
  • New hasRequiredExecutables() method, isValid() is not what we want here (disabled plugins are always invalid).
rthomsen accepted this revision.Dec 18 2016, 9:16 AM
rthomsen edited edge metadata.
This revision is now accepted and ready to land.Dec 18 2016, 9:16 AM

Revision Contents
Changeset List

Diff 9131

View Options

kerfuffle/CMakeLists.txt

Loading...
View Options

kerfuffle/ark.kcfg

Loading...
View Options

kerfuffle/plugin.h

Loading...
View Options

kerfuffle/plugin.cpp

Loading...
View Options

kerfuffle/pluginmanager.cpp

Loading...
View Options

kerfuffle/pluginsettingspage.h

Loading...
View Options

kerfuffle/pluginsettingspage.cpp

Loading...
View Options

kerfuffle/pluginsettingspage.ui

Loading...
View Options

part/part.cpp

Loading...