Differential D3642

Show wheelchair information
ClosedPublic
Actions

Authored by Sergobot on Dec 11 2016, 10:50 AM.

Details

Reviewers
nienhueser
rahn
Commits
R34:3f9b286ac0bb: Show wheelchair information
Summary

Task:
https://phabricator.kde.org/T4868

Related Google Code-In 2016 task:
https://codein.withgoogle.com/dashboard/task-instances/5957761101725696/

Test Plan

Works as expected

Diff Detail

Repository
R34 Marble
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Sergobot updated this revision to Diff 8923.Dec 11 2016, 10:50 AM
Sergobot retitled this revision from to Show wheelchair information.
Sergobot updated this object.
Sergobot edited the test plan for this revision. (Show Details)
Sergobot added reviewers: rahn, nienhueser.
Sergobot added subscribers: rahn, nienhueser.
Sergobot updated this object.Dec 11 2016, 10:51 AM
Sergobot updated this revision to Diff 8924.Dec 11 2016, 11:00 AM

Fix whitespace issues

nienhueser edited edge metadata.Dec 11 2016, 11:28 AM

Looks great. One thing I'm missing is the emission of wheelChairInfoChanged in Placemark::setGeoDataPlacemark(). This is needed for QML to know that it has to update the text it shows.

Sergobot updated this revision to Diff 8925.Dec 11 2016, 11:45 AM
Sergobot edited edge metadata.

Emit wheelchairInfoChanged in Placemark::setGeoDataPlacemark()

rahn added inline comments.Dec 11 2016, 12:08 PM
src/lib/marble/declarative/Placemark.cpp
427 ↗(On Diff #8923)

Any better approach to circumvent the 23 magic number (e.g. by evaluating the string snippet length before the foreach loop).

Sergobot updated this revision to Diff 8926.Dec 11 2016, 12:14 PM
Sergobot marked an inline comment as done.

Remove magic number of 23 in Placemark::wheelchairInfo()

rahn accepted this revision.Dec 11 2016, 12:22 PM
rahn edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2016, 12:22 PM
Closed by commit R34:3f9b286ac0bb: Show wheelchair information (authored by Sergobot, committed by nienhueser). · Explain WhyDec 11 2016, 1:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8924

View Options

src/apps/marble-maps/MarbleMaps.qrc

Loading...
View Options

src/apps/marble-maps/PlacemarkDialog.qml

Loading...
View Options

src/lib/marble/declarative/Placemark.h

Loading...
View Options

src/lib/marble/declarative/Placemark.cpp

Loading...