[effects] Use arg="true" in the kcfg files
ClosedPublic
Actions

Authored by graesslin on Dec 2 2016, 7:30 PM.

Details

Reviewers

Group Reviewers

Plasma
KWin

Commits

R108:2132b1e0c829: [effects] Use arg="true" in the kcfg files

Summary

By changing all kcfg to have arg="true" we can pass in the same
KSharedConfigPtr into all effects. This allows to have fake config in
the tests and in the planned effect demo mode.

Also it means that we don't have to hardcode the name kwinrc into the
files. In the configs - where we cannot access the effectshandler - we
use the define KWIN_CONFIG which gets generated based on the compile
time arguments.

Diff Detail

Repository

R108 KWin

Branch

effects-singleton-arg

Lint

No Linters Available

Unit

No Unit Test Coverage

graesslin updated this revision to Diff 8703.Dec 2 2016, 7:30 PM

graesslin retitled this revision from to [effects] Use arg="true" in the kcfg files.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma.

Restricted Application added a project: KWin. · View Herald TranscriptDec 2 2016, 7:30 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

ping

davidedmundson accepted this revision.Jan 24 2017, 9:53 PM

davidedmundson added a reviewer: davidedmundson.

This revision is now accepted and ready to land.Jan 24 2017, 9:53 PM

Closed by commit R108:2132b1e0c829: [effects] Use arg="true" in the kcfg files (authored by graesslin). · Explain WhyApr 15 2017, 8:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/effects/slidingpopups_test.cpp (8 lines)
M			autotests/mock_effectshandler.h (2 lines)
M			autotests/mock_effectshandler.cpp (7 lines)
M			effects.h (2 lines)
M			effects.cpp (5 lines)
M			effects/blur/blur.cpp (1 line)
M			effects/blur/blur.kcfg (2 lines)
M			effects/blur/blur_config.cpp (2 lines)
M			effects/coverswitch/coverswitch.cpp (1 line)
M			effects/coverswitch/coverswitch.kcfg (2 lines)
M			effects/coverswitch/coverswitch_config.cpp (2 lines)
M			effects/cube/cube.cpp (1 line)
M			effects/cube/cube.kcfg (2 lines)
M			effects/cube/cube_config.cpp (2 lines)
M			effects/cube/cubeslide.cpp (1 line)
M			effects/cube/cubeslide.kcfg (2 lines)
M			effects/cube/cubeslide_config.cpp (2 lines)
M			effects/desktopgrid/desktopgrid.cpp (1 line)
M			effects/desktopgrid/desktopgrid.kcfg (2 lines)
M			effects/desktopgrid/desktopgrid_config.cpp (2 lines)
M			effects/diminactive/diminactive.cpp (1 line)
M			effects/diminactive/diminactive.kcfg (2 lines)
M			effects/diminactive/diminactive_config.cpp (2 lines)
M			effects/fallapart/fallapart.cpp (1 line)
M			effects/fallapart/fallapart.kcfg (2 lines)
M			effects/flipswitch/flipswitch.cpp (1 line)
M			effects/flipswitch/flipswitch.kcfg (2 lines)
M			effects/flipswitch/flipswitch_config.cpp (2 lines)
M			effects/glide/glide.cpp (1 line)
M			effects/glide/glide.kcfg (2 lines)
M			effects/glide/glide_config.cpp (2 lines)
M			effects/kscreen/kscreen.cpp (1 line)
M			effects/kscreen/kscreen.kcfg (2 lines)
M			effects/lookingglass/lookingglass.cpp (1 line)
M			effects/lookingglass/lookingglass.kcfg (2 lines)
M			effects/lookingglass/lookingglass_config.cpp (2 lines)
M			effects/magiclamp/magiclamp.cpp (1 line)
M			effects/magiclamp/magiclamp.kcfg (2 lines)
M			effects/magiclamp/magiclamp_config.cpp (2 lines)
M			effects/magnifier/magnifier.cpp (1 line)
M			effects/magnifier/magnifier.kcfg (2 lines)
M			effects/magnifier/magnifier_config.cpp (2 lines)
M			effects/mouseclick/mouseclick.cpp (1 line)
M			effects/mouseclick/mouseclick.kcfg (2 lines)
M			effects/mouseclick/mouseclick_config.cpp (2 lines)
M			effects/mousemark/mousemark.cpp (1 line)
M			effects/mousemark/mousemark.kcfg (2 lines)
M			effects/mousemark/mousemark_config.cpp (2 lines)
M			effects/presentwindows/presentwindows.cpp (1 line)
M			effects/presentwindows/presentwindows.kcfg (2 lines)
M			effects/presentwindows/presentwindows_config.cpp (2 lines)
M			effects/resize/resize.cpp (1 line)
M			effects/resize/resize.kcfg (2 lines)
M			effects/resize/resize_config.cpp (2 lines)
M			effects/sheet/sheet.cpp (1 line)
M			effects/sheet/sheet.kcfg (2 lines)
M			effects/showfps/showfps.cpp (1 line)
M			effects/showfps/showfps.kcfg (2 lines)
M			effects/showfps/showfps_config.cpp (2 lines)
M			effects/slidingpopups/slidingpopups.cpp (1 line)
M			effects/slidingpopups/slidingpopups.kcfg (2 lines)
M			effects/thumbnailaside/thumbnailaside.cpp (1 line)
M			effects/thumbnailaside/thumbnailaside.kcfg (2 lines)
M			effects/thumbnailaside/thumbnailaside_config.cpp (2 lines)
M			effects/trackmouse/trackmouse.cpp (1 line)
M			effects/trackmouse/trackmouse.kcfg (2 lines)
M			effects/trackmouse/trackmouse_config.cpp (3 lines)
M			effects/windowgeometry/windowgeometry.cpp (1 line)
M			effects/windowgeometry/windowgeometry.kcfg (2 lines)
M			effects/windowgeometry/windowgeometry_config.cpp (2 lines)
M			effects/wobblywindows/wobblywindows.cpp (1 line)
M			effects/wobblywindows/wobblywindows.kcfg (2 lines)
M			effects/wobblywindows/wobblywindows_config.cpp (2 lines)
M			effects/zoom/zoom.cpp (1 line)
M			effects/zoom/zoom.kcfg (2 lines)
M			effects/zoom/zoom_config.cpp (2 lines)
M			libkwineffects/CMakeLists.txt (2 lines)
M			libkwineffects/kwineffects.h (21 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8703	7f16d83		Dec 2 2016, 7:30 PM	★	★
Diff 2	13452	af9f817	R108:2132b1e0c8297435fdc4942e0d679e2ad812e1ba	Apr 15 2017, 8:03 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
422c08a34365	bc15c7aba161	7f16d83e046b	Martin Gräßlin	[effects] Use arg="true" in the kcfg files (Show More…)	Dec 2 2016, 7:27 PM

[effects] Use arg="true" in the kcfg filesClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 8703

autotests/integration/effects/slidingpopups_test.cpp

autotests/mock_effectshandler.h

autotests/mock_effectshandler.cpp

effects.h

effects.cpp

effects/blur/blur.cpp

effects/blur/blur.kcfg

effects/blur/blur_config.cpp

effects/coverswitch/coverswitch.cpp

effects/coverswitch/coverswitch.kcfg

effects/coverswitch/coverswitch_config.cpp

effects/cube/cube.cpp

effects/cube/cube.kcfg

effects/cube/cube_config.cpp

effects/cube/cubeslide.cpp

effects/cube/cubeslide.kcfg

effects/cube/cubeslide_config.cpp

effects/desktopgrid/desktopgrid.cpp

effects/desktopgrid/desktopgrid.kcfg

effects/desktopgrid/desktopgrid_config.cpp

effects/diminactive/diminactive.cpp

effects/diminactive/diminactive.kcfg

effects/diminactive/diminactive_config.cpp

effects/fallapart/fallapart.cpp

effects/fallapart/fallapart.kcfg

effects/flipswitch/flipswitch.cpp

effects/flipswitch/flipswitch.kcfg

effects/flipswitch/flipswitch_config.cpp

effects/glide/glide.cpp

effects/glide/glide.kcfg

effects/glide/glide_config.cpp

effects/kscreen/kscreen.cpp

effects/kscreen/kscreen.kcfg

effects/lookingglass/lookingglass.cpp

effects/lookingglass/lookingglass.kcfg

effects/lookingglass/lookingglass_config.cpp

effects/magiclamp/magiclamp.cpp

effects/magiclamp/magiclamp.kcfg

effects/magiclamp/magiclamp_config.cpp

effects/magnifier/magnifier.cpp

effects/magnifier/magnifier.kcfg

effects/magnifier/magnifier_config.cpp

effects/mouseclick/mouseclick.cpp

effects/mouseclick/mouseclick.kcfg

effects/mouseclick/mouseclick_config.cpp

effects/mousemark/mousemark.cpp

effects/mousemark/mousemark.kcfg

effects/mousemark/mousemark_config.cpp

effects/presentwindows/presentwindows.cpp

effects/presentwindows/presentwindows.kcfg

effects/presentwindows/presentwindows_config.cpp

effects/resize/resize.cpp

effects/resize/resize.kcfg

effects/resize/resize_config.cpp

effects/sheet/sheet.cpp

effects/sheet/sheet.kcfg

effects/showfps/showfps.cpp

effects/showfps/showfps.kcfg

effects/showfps/showfps_config.cpp

effects/slidingpopups/slidingpopups.cpp

effects/slidingpopups/slidingpopups.kcfg

effects/thumbnailaside/thumbnailaside.cpp

effects/thumbnailaside/thumbnailaside.kcfg

effects/thumbnailaside/thumbnailaside_config.cpp

effects/trackmouse/trackmouse.cpp

effects/trackmouse/trackmouse.kcfg

effects/trackmouse/trackmouse_config.cpp

effects/windowgeometry/windowgeometry.cpp

effects/windowgeometry/windowgeometry.kcfg

effects/windowgeometry/windowgeometry_config.cpp

effects/wobblywindows/wobblywindows.cpp

effects/wobblywindows/wobblywindows.kcfg

effects/wobblywindows/wobblywindows_config.cpp

effects/zoom/zoom.cpp

effects/zoom/zoom.kcfg

[effects] Use arg="true" in the kcfg files
ClosedPublic
Actions

Revision Contents
Changeset List