Properly kill BatchExtract jobs
ClosedPublic

Authored by elvisangelaccio on Nov 27 2016, 2:10 PM.

Details

Summary

We need to reimplement KJob::doKill() both in BatchExtract and
BatchExtractJob. In the latter class we use an enum to keep track of which
sub-job we are running and kill it when necessary.

Test Plan

Try to stop a batch-extraction from the system tray and check that the ark
process gets killed.

Diff Detail

Repository
R36 Ark
Branch
stop-batchextractions
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio retitled this revision from to Properly kill BatchExtract jobs.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptNov 27 2016, 2:10 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Nov 27 2016, 3:45 PM
rthomsen edited edge metadata.

Nice work :)

This revision is now accepted and ready to land.Nov 27 2016, 3:45 PM
This revision was automatically updated to reflect the committed changes.