Show uses for call() and {get,set}item()
ClosedPublic
Actions

Authored by flherne on Nov 25 2016, 11:42 PM.

Details

Reviewers

Commits

R53:94ab1eeedba3: Show uses for __call__() and __{get,set}item__()

Summary

Uses of __getitem__() and __setitem__() weren't shown at all.
Uses of __call__() were incorrectly shown as uses of __init__().

This removes ExpressionAst::belongsToCall, because it's always equal to ExpressionAst::parent or null.

This adds a new parameter isAlias to functionForCalled(), which allows it to distinguish between calling a class object (constructor __init__()) and calling an instance of that class with __call__().

This parameter can (and probably should) be used in other callers to improve parsing or just simplify code. For now, the default value of true causes functionForCalled() to behave as before.

Test Plan

No test regressions. No new tests, because the test framework doesn't seem to support use ranges currently.

Tested on some real projects, didn't crash.

Diff Detail

Repository

R53 KDevelop: Python Support

Lint

Lint Skipped

Unit

Unit Tests Skipped

flherne updated this revision to Diff 8527.Nov 25 2016, 11:42 PM

flherne retitled this revision from to Show uses for __call__() and __{get,set}item__().

flherne updated this object.

flherne edited the test plan for this revision. (Show Details)

flherne added a reviewer: brauch.

flherne set the repository for this revision to R53 KDevelop: Python Support.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 25 2016, 11:42 PM

Looks good to me. Feel free to rename things, esp. lots of functions could really have better names. Using what is now called functionDeclarationForCalledDeclaration in more places sounds very sensible as well.

As a regression test by the way, I recommend downloading a large python project (e.g. pypy) and just running duchainify on it (built in debug). That is quite good in triggering obscure crashes.

Very nice of you to tidy this up!

This revision is now accepted and ready to land.Nov 26 2016, 1:54 AM

nalvarez updated this object.Nov 26 2016, 2:34 AM

nalvarez edited edge metadata.

Rebased on top of https://paste.kde.org/pk5cglavm (patch to rename functionDeclarationForCalledDeclaration to functionForCalled, and change its signature slightly).

Split visitCall() into its own method, where it was previously bodged into visitName().

Now show uses for call() when the value doesn't have a declaration (most commonly, like container[0](args)).

Closed by commit R53:94ab1eeedba3: Show uses for __call__() and __{get,set}item__() (authored by flherne). · Explain WhyNov 30 2016, 8:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			duchain/helpers.h (3 lines)
M			duchain/helpers.cpp (16 lines)
M			duchain/usebuilder.h (3 lines)
M			duchain/usebuilder.cpp (78 lines)
M			parser/ast.h (1 line)
M			parser/ast.cpp (2 lines)
M			parser/generated.h (1 line)
M			parser/python35.sdef (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8527			Nov 25 2016, 11:38 PM	★	★
Diff 2	8557			Nov 27 2016, 10:24 PM	★	★
Diff 3	8580			Nov 29 2016, 12:45 AM	★	★
Diff 4	8623	d757d25	R53:94ab1eeedba313c85b966b447223a05af3091133	Nov 30 2016, 8:40 AM	★	★