Cursors are drawn low level, so need to go from global compositor space to device space
(multiplied by the out scale)
Details
Details
- Reviewers
graesslin - Group Reviewers
Plasma - Commits
- R108:add93b3e3655: drm cursor scaling
Elements interacted underneath where the mouse was
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| plugins/platforms/drm/drm_output.cpp | ||
|---|---|---|
| 111–112 | that just cannot work in a multi screen setup. The global pos is in combined coordinates and you apply here a scale for a single screen. | |
| plugins/platforms/drm/drm_output.cpp | ||
|---|---|---|
| 111–112 | Yes it can. And does. The combined co-ordinates are all at scale 1. With the screen "sizes" at scale 1. We only need to scale here so it renders in the right place; which is where the per screen part comes in. | |
Comment Actions
I cannot help it: to me it looks wrong.
| plugins/platforms/drm/drm_output.cpp | ||
|---|---|---|
| 111 | const QPoint p = (globalPos - m_globalPos) * m_scale; | |