Differential D3435

Support gcc < 5
AbandonedPublic
Actions

Authored by ervin on Nov 21 2016, 3:57 PM.

Details

Reviewers
dfaure
shumski
Group Reviewers
Zanshin
Summary

There are a few issues which prevented zanshin to compile on openSUSE Leap.

Test Plan

Compiles on openSUSE Leap 42.1 & 42.2.

Diff Detail

Repository
R4 Zanshin
Branch
supportgccversionless5 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
shumski updated this revision to Diff 8346.Nov 21 2016, 3:57 PM
shumski retitled this revision from to Support gcc < 5.
shumski updated this object.
shumski edited the test plan for this revision. (Show Details)
dfaure edited edge metadata.Nov 21 2016, 4:42 PM

Moving the find_package calls was just a first try, it's not strictly necessary, right?

(I probably know why you did it, the wrong compiler flag made the libical detection fail due to the unknown compiler flag - I improved FindLibIcal to show the full error message due to that issue...)

But with your fix, moving the find_package calls is probably unnecessary (I'll let Kévin decide where he prefers them though).

shumski added a comment.Nov 21 2016, 9:15 PM
In D3435#64101, @dfaure wrote:

Moving the find_package calls was just a first try, it's not strictly necessary, right?

(I probably know why you did it, the wrong compiler flag made the libical detection fail due to the unknown compiler flag - I improved FindLibIcal to show the full error message due to that issue...)

But with your fix, moving the find_package calls is probably unnecessary (I'll let Kévin decide where he prefers them though).

True. It was 1st step which bypassed libical error, but only setting c++1y flag really fixed that error.

ervin requested changes to this revision.Nov 22 2016, 5:53 PM
ervin edited edge metadata.
ervin added inline comments.
CMakeLists.txt
16–26

If this move was indeed not necessary, please put this block back to its original place.

This revision now requires changes to proceed.Nov 22 2016, 5:53 PM
ervin added a comment.Apr 18 2017, 10:10 AM

Any chance to see this updated and addressing the comments? Otherwise I'd propose to close it.

ervin commandeered this revision.Aug 16 2017, 8:09 AM
ervin abandoned this revision.
ervin edited reviewers, added: shumski; removed: ervin.

Doesn't look like my comments are going to be addressed, closing it for now.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (29 lines)
Msrc/widgets/applicationcomponents.cpp (2 lines)

Diff 8346

View Options

CMakeLists.txt

Loading...
View Options

src/widgets/applicationcomponents.cpp

Loading...