Manage PackageKit database refresh
ClosedPublic
Actions

Authored by apol on Nov 21 2016, 2:54 PM.

Details

Reviewers

sitter

Commits

R134:0e271924e5d0: Manage PackageKit database refresh

Summary

Refresh the packagekit database every day and 5 minutes after starting
the notifier

Repository

R134 Discover Software Store

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol retitled this revision from to Manage PackageKit database refresh.

apol updated this object.

apol edited the test plan for this revision. (Show Details)

apol added a reviewer: sitter.

lgtm

This revision is now accepted and ready to land.Nov 21 2016, 2:57 PM

This revision was automatically updated to reflect the committed changes.

mak added inline comments.

libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp
33	This is likely not doing what you think it does... The daemon is started on-demand when you make a call on the PackageKit interface, and auto-quits after it has been idle for a while. So, the code below this will only be triggered if the daemon happens to be running as per request of another tool or query. Anyway, no issue in this patch though.

libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp
33	Given the new `refreshDatabase` calls `recheckSystemUpdateNeeded` based on a signal out of the daemon it should be fine. But yeah, this if block can go entirely given this new behavior. Additionally the same isRunning guard probably should be dropped from `recheckSystemUpdateNeeded` as it is fairly useless there.

			Path	Packages
M			libdiscover/backends/PackageKitBackend/PackageKitNotifier.h (3 lines)
M			libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8344	5a3b4da		Nov 21 2016, 2:54 PM	★	★
Diff 2	8345	5a3b4da	rDISCOVER0e271924e5d093c080622519187a5fc3e4fad86e	Nov 21 2016, 3:47 PM	★	★