Differential D3433

tabbar on proper side when ltr
ClosedPublic
Actions

Authored by mart on Nov 21 2016, 2:25 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R119:460ea235894e: tabbar on proper side when ltr
Summary

when the layout is mirrored, the anchors are too, we end
up on the tabbar anchored to the wrong side, swap left and right states
when the application is mirrored, to keep the tabbar against the panel

BUG:372720

Test Plan

tried with plasmashell both normally and with --reverse parameter
in both cases in vertical panels tabbar is on panel side

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 8343.Nov 21 2016, 2:25 PM
mart retitled this revision from to tabbar on proper side when ltr.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 21 2016, 2:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Nov 21 2016, 2:26 PM
broulik added inline comments.
applets/kickoff/package/contents/ui/FullRepresentation.qml
174

Perhaps better check whether LayoutMirroring.enabled

mart added inline comments.Nov 21 2016, 2:33 PM
applets/kickoff/package/contents/ui/FullRepresentation.qml
174

ha! actually it's never enabled, investigating more

mart updated this revision to Diff 8347.Nov 21 2016, 4:07 PM
  • move layout mirroring top level
broulik added inline comments.Nov 21 2016, 5:33 PM
applets/kickoff/package/contents/ui/FullRepresentation.qml
48

I wonder why this should be neccessary (I know it has been there before) but CompactApplet, DefaultCompactRepresentation and virtually all other places add this to the Dialog that holds the applet, so it should just work?

mart marked 2 inline comments as done.Nov 21 2016, 5:48 PM
mart added inline comments.
applets/kickoff/package/contents/ui/FullRepresentation.qml
48

doesn't seem to correctly work without.
the weird thing is that some of the elements do appear flipped (like arrows for submenus) but most of the ui elements aren't.

perhaps childrenInherit doesn't really work for things that are reparented later?

mart updated this revision to Diff 8383.Nov 22 2016, 9:55 AM
  • manual layout mirroring not necessary
Closed by commit R119:460ea235894e: tabbar on proper side when ltr (authored by mart). · Explain WhyNov 22 2016, 9:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8384

View Options

applets/kickoff/package/contents/ui/FullRepresentation.qml

Loading...