Get more possible types when subscripting.
ClosedPublic
Actions

Authored by flherne on Nov 20 2016, 1:41 PM.

Details

Reviewers

Commits

Summary

Before, foo[a] would only consider one possible type of foo.
Loop over all possible types and combine the values for each.

This requires https://phabricator.kde.org/D3422 to apply cleanly, but isn't closely tied to it.

Test Plan

No test regressions. Adds three new tests, two of which fail without this patch.

Tried it on a few of my projects, it didn't crash.

Repository

R53 KDevelop: Python Support

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

flherne retitled this revision from to Get more possible types when subscripting..

flherne updated this object.

flherne edited the test plan for this revision. (Show Details)

flherne added a reviewer: brauch.

flherne set the repository for this revision to R53 KDevelop: Python Support.

Looks good to me, good feature as well. Thanks once more!

duchain/expressionvisitor.cpp
373	You could replace this whole if/else by auto valueTypes = Helper::filterType(type, []() { return true; }); if you wanted. By the way, feel free to replace any QList you find anywhere by QVector ... it's a relict.

This revision is now accepted and ready to land.Nov 20 2016, 3:22 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			duchain/expressionvisitor.cpp (71 lines)
M			duchain/tests/pyduchaintest.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8330			Nov 20 2016, 1:27 PM	★	★
Diff 2	8332	3a534db	rKDEVPYTHON257246616406f136edba73644b33c49bbd5c54fa	Nov 20 2016, 3:48 PM	★	★