Pass AbstractType::Ptr, not Declaration*, to accessAttribute()
ClosedPublic
Actions

Authored by flherne on Nov 18 2016, 8:31 PM.

Details

Reviewers

Commits

Summary

All but one caller had to look up the declaration only to have it converted back, so the previous version was pointless anyway.

This allows subscripting of expressions (inc. other subscripts), when the subscripted type isn't a ListType/IndexedContainer.

BUG: 359912

Test Plan

No test regressions or new compile warnings.

Added both examples from https://bugs.kde.org/show_bug.cgi?id=359912 to the test suite; they fail without this patch and pass with it.

Repository

R53 KDevelop: Python Support

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

flherne retitled this revision from to Pass AbstractType::Ptr, not Declaration*, to accessAttribute().

flherne updated this object.

flherne edited the test plan for this revision. (Show Details)

flherne set the repository for this revision to R53 KDevelop: Python Support.

flherne edited the test plan for this revision. (Show Details)

flherne added a reviewer: brauch.

As you say, obviously pointless code before. Thank you!

This revision is now accepted and ready to land.Nov 20 2016, 3:16 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			duchain/declarationbuilder.cpp (2 lines)
M			duchain/expressionvisitor.cpp (9 lines)
M			duchain/helpers.h (2 lines)
M			duchain/helpers.cpp (6 lines)
M			duchain/tests/pyduchaintest.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8317			Nov 18 2016, 8:09 PM	★	★
Diff 2	8318			Nov 18 2016, 9:00 PM	★	★
Diff 3	8331	9139213	rKDEVPYTHON3a534dbb961fa3757e7066583b5a24c16525ea5f	Nov 20 2016, 3:48 PM	★	★