Fix race condition in KisMergeWalker::startTripWithMask
ClosedPublic
Actions

Authored by gladhorn on Nov 16 2016, 4:21 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

The parent pointer could become null right after the check.
Making it safe is easy, just hold on to the pointer for the duration
of the function.

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

gladhorn retitled this revision from to Fix race condition in KisMergeWalker::startTripWithMask.

gladhorn updated this object.

gladhorn edited the test plan for this revision. (Show Details)

gladhorn added a reviewer: Krita.

dkazakov added a reviewer: dkazakov.

This revision is now accepted and ready to land.Nov 16 2016, 4:22 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libs/image/kis_merge_walker.cc (29 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8229	e15336a		Nov 16 2016, 4:21 PM	★	★
Diff 2	8230	11f0acc	rKRITA2994b9824edfec32b4b5cb17c4188394b226db24	Nov 16 2016, 4:24 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a5a1e41d6d84	c5d424e07183	e15336a0973b	Frederik Gladhorn	Fix race condition in KisMergeWalker::startTripWithMask (Show More…)	Nov 16 2016, 4:20 PM