Use KWin's KSharedConfigPtr in ScriptedEffect
ClosedPublic

Authored by graesslin on Nov 16 2016, 12:46 PM.

Details

Summary

So far ScriptedEffect used EffectsHandler::effectConfig to get the
KConfigGroup for the ScriptedEffect. This has the disadvantage that the
config file name is hardcoded to kwinrc in EffectsHandler::effectConfig.

Inside KWin a KSharedConfigPtr is used which can point to somwhere else
than kwinrc. If that was the case the ScriptedEffects were not able to
pick up this customized config and instead continued to read values from
kwinrc.

With this change the ScriptedEffects use the KSharedConfigPtr provided
by KWin. Thus in e.g. autotests we can use the general way to configure
the effects and don't need to write to the config.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 8217.Nov 16 2016, 12:46 PM
graesslin retitled this revision from to Use KWin's KSharedConfigPtr in ScriptedEffect.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptNov 16 2016, 12:46 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Nov 16 2016, 12:48 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Nov 16 2016, 12:48 PM
This revision was automatically updated to reflect the committed changes.