VirtualDesktopGrid operates on VirtualDesktop objects
ClosedPublic

Authored by graesslin on Nov 10 2016, 1:08 PM.

Details

Summary

The VirtualDesktopGrid is ported to the new VirtualDesktop objects. The
grid consists now of QVector<VirtualDesktop*> rows and a QVector of
those rows.

This change requires to adjust the code using the VirtualDesktopGrid.
This mostly affects VirtualDesktopManger. The methods for toLeft, above,
next, etc are now all operating on VirtualDesktop with the uint variants

  • if still present - only delegating to the new method. The Functor

objects are also adjusted, though mostly still providing the old API for
compatibility.

In KWin core only one now ambiguous call is adjusted (useractions) and
the desktop grid usage in EffectsHandlerImpl is adjusted. Other usages
are not yet adjusted and need porting to fully get rid of the old
uint-based API.

Test Plan

VD test still passes

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 8065.Nov 10 2016, 1:08 PM
graesslin retitled this revision from to VirtualDesktopGrid operates on VirtualDesktop objects.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland, hein.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptNov 10 2016, 1:08 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
hein accepted this revision.Nov 11 2016, 10:46 AM
hein edited edge metadata.
This revision is now accepted and ready to land.Nov 11 2016, 10:46 AM
This revision was automatically updated to reflect the committed changes.