Differential D3318

[Task Manager] Fix Unity launcher count badge rendering when task is created
ClosedPublic
Actions

Authored by broulik on Nov 9 2016, 4:03 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:87579efbe4f3: [Task Manager] Fix Unity launcher count badge rendering when task is created
Summary

When moving a window that currently has a count badge between screens, the newly created task on the other screen will have a glitched out badge overlay.

The anchors.fill didn't reliably work with the Loader, it seems it tries to deduce a size from the item it loaded which is rubbish. Forcing a width/height explicitly fixes this.

Test Plan

I can now move windows between screens without the badge glitching out.


Broken overlay before

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 8040.Nov 9 2016, 4:03 PM
broulik retitled this revision from to [Task Manager] Fix Unity launcher count badge rendering when task is created.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 9 2016, 4:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Nov 9 2016, 4:10 PM
hein edited edge metadata.
This revision is now accepted and ready to land.Nov 9 2016, 4:10 PM
Closed by commit R119:87579efbe4f3: [Task Manager] Fix Unity launcher count badge rendering when task is created (authored by broulik). · Explain WhyNov 9 2016, 5:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8040

View Options

applets/taskmanager/package/contents/ui/Task.qml

Loading...