Differential D3307

Deprecate direct pointer accessors in KisWeakSharedPtr
Needs ReviewPublic
Actions

Authored by gladhorn on Nov 8 2016, 8:32 AM.

Details

Reviewers
None
Group Reviewers
Krita

Diff Detail

Repository
R37 Krita
Branch
rempt/impex-refactoring
Lint
No Linters Available
Unit
No Unit Test Coverage
gladhorn updated this revision to Diff 8004.Nov 8 2016, 8:32 AM
gladhorn retitled this revision from to Deprecate direct pointer accessors in KisWeakSharedPtr.
rempt added a subscriber: rempt.Nov 14 2016, 4:15 PM

I guess this would give a gazillion warnings :-) But I do agree with it being necessary.

gladhorn added a comment.Nov 14 2016, 5:48 PM

Yes, maybe it's a bit early, I think it's "only" 1000 or so warnings, but currently still a bit much. I'll try to clean up a few more warnings before landing this I think...

dkazakov mentioned this in D3326: Add shared pointers rules to ./HACKING.Nov 16 2016, 3:49 PM
dkazakov added a subscriber: dkazakov.

Yep, seeing all these warnings in master is a bad idea :)

Revision Contents
Changeset List

PathPackages
Mlibs/global/kis_shared_ptr.h (4 lines)

Diff 8004

View Options

libs/global/kis_shared_ptr.h

Loading...