[Stream] Expose "corked" property
ClosedPublic
Actions

Authored by broulik on Nov 7 2016, 3:28 PM.

Details

Reviewers

drosca

Group Reviewers

Plasma

Commits

Summary

It denotes whether there is actually something going on on a playback stream vs it merely existing.

Test Plan

Pressed pause in my music player, "corked" became true

Repository

R115 Plasma Audio Volume Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [Stream] Expose "corked" property.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added reviewers: Plasma, drosca.

broulik set the repository for this revision to R115 Plasma Audio Volume Applet.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

drosca edited edge metadata.

drosca added inline comments.

src/stream.h
82	The getter for `corked` property should be `isCorked()`.

This revision is now accepted and ready to land.Nov 7 2016, 4:07 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/stream.h (8 lines)
M			src/stream.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7983			Nov 7 2016, 3:20 PM	★	★
Diff 2	8009	3c76096	rPLASMAPAc64fe1cfcf347ced1d4957b247d7a23571a5dc2d	Nov 8 2016, 10:51 AM	★	★