Differential D3298

[libkwineffects] Delete EffectsHandler::deleteRootProperty
ClosedPublic
Actions

Authored by graesslin on Nov 7 2016, 3:04 PM.

Details

Reviewers
bshah
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:3041b871ea2c: [libkwineffects] Delete EffectsHandler::deleteRootProperty
Summary

The method is not used by any Effect and is X11 specific, thus better
remove it for good.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7981.Nov 7 2016, 3:04 PM
graesslin retitled this revision from to [libkwineffects] Delete EffectsHandler::deleteRootProperty.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptNov 7 2016, 3:04 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
bshah accepted this revision.Nov 16 2016, 6:35 AM
bshah added a reviewer: bshah.
bshah added a subscriber: bshah.

Assuming this doesn't break any other 3rd party effects(?)

This revision is now accepted and ready to land.Nov 16 2016, 6:35 AM
graesslin added a comment.Nov 16 2016, 6:42 AM
In D3298#62976, @bshah wrote:

Assuming this doesn't break any other 3rd party effects(?)

To my knowledge there are no 3rd party effects. And even if: we broke the ABI in 5.9 already, so at least a recompile is needed. Given that the method is not even documented I consider it unlikely that it was used

Closed by commit R108:3041b871ea2c: [libkwineffects] Delete EffectsHandler::deleteRootProperty (authored by graesslin). · Explain WhyNov 16 2016, 6:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/mock_effectshandler.h (1 line)
Meffects.h (1 line)
Meffects.cpp (5 lines)
Mlibkwineffects/kwineffects.h (1 line)

Diff 8190

View Options

autotests/mock_effectshandler.h

Loading...
View Options

effects.h

Loading...
View Options

effects.cpp

Loading...
View Options

libkwineffects/kwineffects.h

Loading...