[effects] Improve interaction between Glide and SlidingPopups effect
ClosedPublic

Authored by graesslin on Nov 7 2016, 2:40 PM.

Details

Summary

The glide effect tried to not animate any window the SlidingPopups
effect animates. But it detected that in a very crude way. It announced
the KDE_SLIDE atom and checked for windows having that property set.

This has a few disadvantages:

  • KWindowEffects::isEffectAvailable gets confused as an effect announces support for SlidingPopups which doesn't provide SlidingPopups
  • The approach can only work for X11 windows
  • The approach causes X11 usage in the ctor

With this change the GlideEffect implements a slot for
EffectsHandler::windowDataChanged to detect that the SlidingPopupsEffect
grabbed the window. The X11 atom interaction is removed.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7977.Nov 7 2016, 2:40 PM
graesslin retitled this revision from to [effects] Improve interaction between Glide and SlidingPopups effect.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptNov 7 2016, 2:40 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
bshah accepted this revision.Nov 16 2016, 6:54 AM
bshah added a reviewer: bshah.
bshah added a subscriber: bshah.

sounds sane.

This revision is now accepted and ready to land.Nov 16 2016, 6:54 AM
This revision was automatically updated to reflect the committed changes.