libarchive: stop using xi18nc in errors
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 6 2016, 11:01 AM.

Details

Reviewers

rthomsen

Maniphest Tasks

T4126: Fix libarchive plugin error messages

Summary

They break the markup otherwise. Also don't use untraslated messages from
libarchive.

Repository

R36 Ark

Branch

libarchive-errors

Lint

No Linters Available

Unit

No Unit Test Coverage

elvisangelaccio retitled this revision from to libarchive: stop using xi18nc in errors.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

Restricted Application added a project: Ark. · View Herald TranscriptNov 6 2016, 11:01 AM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

Fix and commit :)

plugins/libarchive/readwritelibarchiveplugin.cpp
310	Missing period at end of sentence.
363	Missing period at end of sentence.
373	Missing period at end of sentence.
523	Missing period at end of sentence.

This revision is now accepted and ready to land.Nov 13 2016, 6:43 PM

Submitted.

			Path	Packages
M			plugins/libarchive/libarchiveplugin.cpp (8 lines)
M			plugins/libarchive/readwritelibarchiveplugin.cpp (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7938	6c83f46		Nov 6 2016, 11:01 AM	★	★