Differential D3256

Close popups on escape
ClosedPublic
Actions

Authored by davidedmundson on Nov 4 2016, 9:39 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:02674a356340: Close popups on escape
Summary

A lot of applets have independent handling making escape close the
expanded representation. However not all of them do.

This leads to both duplicated code and inconsistencies, so we should
tackle this at the source.

If an applet was already using escape internally it will be accepting
the event, and so this code will not cause any regressions.

CCBUG: 362657

Test Plan

Opened a bunch of popups. Pressed escape

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 7884.Nov 4 2016, 9:39 AM
davidedmundson retitled this revision from to Close popups on escape.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 4 2016, 9:39 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Nov 4 2016, 9:44 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Nov 4 2016, 9:44 AM
mart added a comment.Nov 4 2016, 9:48 AM

speaking of which, i'm noticing the systray has its own popup and no esc, so adding the same thing there right now

mart added a comment.Nov 4 2016, 9:51 AM
In D3256#60552, @mart wrote:

speaking of which, i'm noticing the systray has its own popup and no esc, so adding the same thing there right now

ah, seen now your other rr for the tray, nevermind :)

Closed by commit R119:02674a356340: Close popups on escape (authored by davidedmundson). · Explain WhyNov 4 2016, 11:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7893

View Options

desktoppackage/contents/applet/CompactApplet.qml

Loading...