Differential D3252

Makes it possible to send sms from kdeconnect-cli
ClosedPublic
Actions

Authored by apol on Nov 3 2016, 6:22 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:7d88340da7cd: Makes it possible to send sms from kdeconnect-cli
Summary

Introduces --send-sms and --destination

Test Plan

Sent an sms to Albert Vaca

Diff Detail

Repository
R224 KDE Connect
Branch
1.x
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 7871.Nov 3 2016, 6:22 PM
apol retitled this revision from to Makes it possible to send sms from kdeconnect-cli.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added a reviewer: albertvaka.
albertvaka added inline comments.Nov 3 2016, 7:33 PM
cli/kdeconnect-cli.cpp
194
  • Missing i18n()? Or we don't translate error messages?
  • Return a non-zero error code and don't let the execution continue after the if.
  • Nitpicky: "SMS" should be capitalized.
apol updated this revision to Diff 7877.Nov 4 2016, 12:46 AM

Address Albert's concerns

albertvaka accepted this revision.Nov 4 2016, 11:07 AM
albertvaka edited edge metadata.
This revision is now accepted and ready to land.Nov 4 2016, 11:07 AM
Closed by commit R224:7d88340da7cd: Makes it possible to send sms from kdeconnect-cli (authored by apol). · Explain WhyNov 4 2016, 11:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7871

View Options

cli/kdeconnect-cli.cpp

Loading...
View Options

plugins/telephony/telephonyplugin.h

Loading...
View Options

plugins/telephony/telephonyplugin.cpp

Loading...