Differential D3232

[Lock Screen] Don't assume last user is "New Session" entry
ClosedPublic
Actions

Authored by broulik on Nov 2 2016, 4:24 PM.

Details

Reviewers
davidedmundson
romangg
Group Reviewers
Plasma
Commits
R871:d1133288c335: [Lock Screen] Don't assume last user is "New Session" entry
R120:d1133288c335: [Lock Screen] Don't assume last user is "New Session" entry
Summary

Ask the model instead. The entry might not be there if the user is not allowed to start a new session

Test Plan

Creating new sessions (didn't know there was magic code in the session model that switching to a negative VT would start a new session...) and switching still works. Button label is also correct, even if I'm not allowed to create a new session and I select the last user.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 7835.Nov 2 2016, 4:24 PM
broulik retitled this revision from to [Lock Screen] Don't assume last user is "New Session" entry.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, romangg.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 2 2016, 4:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Nov 2 2016, 4:37 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Nov 2 2016, 4:37 PM
Closed by commit R120:d1133288c335: [Lock Screen] Don't assume last user is "New Session" entry (authored by broulik). · Explain WhyNov 3 2016, 3:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7865

View Options

lookandfeel/contents/lockscreen/LockScreenUi.qml

Loading...