Disable starting kactivitymanagerd throughout launchertasksmodeltest
ClosedPublic
Actions

Authored by davidedmundson on Nov 2 2016, 1:18 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Currently kactivitymanagerd is loaded halfway through this test, which
has the net result of just breaking.

The test doesn't need it and still passes without it.

Test Plan

Ran the unit test that's been failing on CI for ages.
It used to fail locally (if run in a new session, see my email on plasma-devel)
now it passes.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson retitled this revision from to Disable starting kactivitymanagerd throughout launchertasksmodeltest.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

LGTM +1

libtaskmanager/autotests/launchertasksmodeltest.cpp
47	Added a blank line?

Looks fine modulo apol's issue.

This revision is now accepted and ready to land.Nov 3 2016, 4:05 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libtaskmanager/autotests/launchertasksmodeltest.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7831	bd0eb99		Nov 2 2016, 1:18 PM	★	★
Diff 2	7854	bd0eb99	rPLASMAWORKSPACEb63b2924254a96fda6cd6535d295f82aba2249e2	Nov 3 2016, 10:29 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
4b2e17596116	92d638677d89	bd0eb992d8d9	David Edmundson	Disable starting kactivitymanagerd throughout launchertasksmodeltest (Show More…)	Nov 2 2016, 1:17 PM