Differential D3228

[helpers/killer] Force to platform XCB
ClosedPublic
Actions

Authored by graesslin on Nov 2 2016, 1:14 PM.

Details

Reviewers
mart
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:f3325a1cb801: [helpers/killer] Force to platform XCB
Summary

The killer can only kill X11 windows. It is also only invoked for Client
and not for ShellClient. The tool interacts with QX11Info which means it
would crash if tried to use on Wayland.

Thus force platform xcb on the tool.

Test Plan

Killer shows for Xwayland windows.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7830.Nov 2 2016, 1:14 PM
graesslin retitled this revision from to [helpers/killer] Force to platform XCB.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptNov 2 2016, 1:14 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Nov 4 2016, 10:22 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Nov 4 2016, 10:22 AM
Closed by commit R108:f3325a1cb801: [helpers/killer] Force to platform XCB (authored by graesslin). · Explain WhyNov 7 2016, 10:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhelpers/killer/killer.cpp (1 line)

Diff 7958

View Options

helpers/killer/killer.cpp

Loading...