| mart |
| Plasma |
layout.js used to be run before any containments were added. This was
broken in a697d291 which creates desktop containments for that activity
first.
However, some scripts rely on being able to alter global configuration
before any containments are loaded.
In order to allow the same functionality we need to provide a new hook
for whatever these scripts may need to do.
BUG: 371704
Not done yet.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
a bit on the fence on this: is true that this would solve the problem in an elegant way, but would make things more complicated for distributions, adding a new thing to pay attention to and a new thing in which is possible to do wrong things.
in general, not against it, just not too sure.
do you think it could go in 5.8 as well? (i think it should as distros needs fix there too)
| shell/shellcorona.cpp | ||
|---|---|---|
| 884 | Why reuse the variable? they can have different names... :/ | |
| shell/shellcorona.cpp | ||
|---|---|---|
| 884 | what problem can it cause? the value is overwritten anyways there, so there shouldn't be the risk of the old script being executed twice? | |
Let's go with this, maybe use two different wariables for the script paths, but let's go with it.
even if is a new thing, it should go on 5.8 as well tough.