WIP: Restore Menubar style config in application style
ClosedPublic

Authored by broulik on Oct 31 2016, 4:05 PM.

Details

Summary

This restores the configuration for whether menus should be shown in the application (no global menu), as title bar button, or as "widget".

The notification popup is removed and replaced by a simple KMessageWidget. The option "Application Menu widget" doesn't actually do anything, it just enables global menu but not visible to the user. Perhaps it should show a hint, like "Place the Application Menu widget in a panel" or something like that.

Test Plan

Placement for the message widget needs fixing.

When I change the style from inapp to something else it shows that this setting will only work after restarting the respective app. The title bar button in KWin comes and goes as I change it to "title bar button" or something else.

Technically, you could use window decoration button and the appmenu applet simultaneously (nothing keeps you from placing a appmenu widget even while it's set to title bar button) but that will cause interaction problems, eg. who's turn is it if I press Alt?
The plasma applet could even say "application menu applet is currently not enabled [enable]" so we really allow only one of the two (we need something like this anyway when you disable appmenu and you have the applet)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 7786.Oct 31 2016, 4:05 PM
broulik retitled this revision from to WIP: Restore Menubar style config in application style.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 31 2016, 4:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Dec 16 2016, 11:27 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

what's with the notifyrc change?

This revision is now accepted and ready to land.Dec 16 2016, 11:27 PM

There was a "you need to restart in order for appmenu changes to take effect" notification in notifyrc

This revision was automatically updated to reflect the committed changes.