Differential D3191

guard against dataengine missing
ClosedPublic
Actions

Authored by mart on Oct 28 2016, 2:53 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R114:360036fb0bdc: guard against dataengine missing
R114:03e7a6740f99: guard against dataengine missing
Summary

this should never happen, but weird distribution packaging policies
can make this happen. At least don't crash the whole sesison

CCBUG:371779

Test Plan

with dataengine present still works, with dataengine plugin delteted
it still load without crashing, even if broken

Diff Detail

Repository
R114 Plasma Addons
Branch
arcpatch-D3191_1
Lint
No Linters Available
Unit
No Unit Test Coverage
mart updated this revision to Diff 7733.Oct 28 2016, 2:53 PM
mart retitled this revision from to guard against dataengine missing.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 28 2016, 2:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.Oct 28 2016, 3:18 PM

So why is PluginLoader::loadDataEngine returning something?

mart added a comment.Oct 31 2016, 10:18 AM
In D3191#59338, @davidedmundson wrote:

So why is PluginLoader::loadDataEngine returning something?

from https://bugs.kde.org/show_bug.cgi?id=371779 it looks like it's not?

davidedmundson added a comment.Oct 31 2016, 10:25 AM

So then checking isValid() is useless.

mart updated this revision to Diff 7790.Oct 31 2016, 5:10 PM
  • remove unneeded isValid() calls
davidedmundson accepted this revision.Oct 31 2016, 5:15 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Oct 31 2016, 5:15 PM
Closed by commit R114:03e7a6740f99: guard against dataengine missing (authored by mart). · Explain WhyNov 1 2016, 8:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/comic/comic.cpp (42 lines)
Mapplets/comic/comicmodel.cpp (4 lines)

Diff 7790

View Options

applets/comic/comic.cpp

Loading...
View Options

applets/comic/comicmodel.cpp

Loading...