Differential D3190

[effects/translucency] Cancel existing animations before starting new
ClosedPublic
Actions

Authored by graesslin on Oct 28 2016, 12:45 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
KWin
Commits
R108:94c5704af74d: [effects/translucency] Cancel existing animations before starting new
Summary

It can happen that startAnimation is invoked multiple times for a
window. In case it was invoked a second time the previous animation was
not cancelled. This resulted in the set-animation to never end. When
closing a window, it would stay around as a translucent, non-interactive
window zombie.

This change ensures that existing animations get cancelled.

BUG: 342716
FIXED-IN: 5.8.3

Test Plan

Tested through autotest and manually.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7724.Oct 28 2016, 12:45 PM
graesslin retitled this revision from to [effects/translucency] Cancel existing animations before starting new.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptOct 28 2016, 12:45 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Oct 28 2016, 1:39 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Oct 28 2016, 1:39 PM
Closed by commit R108:94c5704af74d: [effects/translucency] Cancel existing animations before starting new (authored by graesslin). · Explain WhyOct 28 2016, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7731

View Options

autotests/integration/effects/translucency_test.cpp

Loading...
View Options

effects/translucency/package/contents/code/main.js

Loading...