Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILES
ClosedPublic

Authored by apol on Oct 27 2016, 2:40 PM.

Details

Summary

Instead of having an odd fake of it. Will help some required
refactorings and already showed some issues, fixed by this patch,
namely:

  • don't use string(regex replace) to extract a string from another

string. in case it doesn't match it will offer the whole content which
is never what we want.

  • messages(ERROR), the correct parameter is FATAL_ERROR, cmake

understands "ERROR" as mere output string

  • turn the macro into a function, otherwise 2 calls in the same

subdirectory are dangerous.

CCBUG: 371562

Test Plan

tests still pass, projects that use the macro still build

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 7700.Oct 27 2016, 2:40 PM
apol retitled this revision from to Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILES.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added a reviewer: Frameworks.
apol updated this revision to Diff 7717.Oct 28 2016, 10:53 AM

Make sure concatenation works properly

apol updated this revision to Diff 7721.Oct 28 2016, 12:21 PM

Far too many projects rely on this bug, can't make it fatal

dfaure accepted this revision.Oct 30 2016, 10:16 AM
dfaure added a reviewer: dfaure.
dfaure added a subscriber: dfaure.

Looks sensible to me.

This revision is now accepted and ready to land.Oct 30 2016, 10:16 AM
apol closed this revision.Oct 30 2016, 11:28 PM