Implementation of PointerGestures protocol
ClosedPublic

Authored by graesslin on Oct 26 2016, 3:08 PM.

Details

Summary

Pointer gestures are created for a pointer and there are two types of
gestures: swipe and pinch.

At a given time there can only be one active gesture. The implementation
in SeatInterface ensures that there can only be one active gesture.

Each gesture consists of a start event, 0 to multiple update events and
an end event. The end can also be a cancel. To better support this the
implementation doesn't follow the protocol and splits end and cancel
into dedicated methods in the server side and into dedicated signals in
the client side.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7675.Oct 26 2016, 3:08 PM
graesslin retitled this revision from to Implementation of PointerGestures protocol.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a project: Plasma on Wayland. · View Herald TranscriptOct 26 2016, 3:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin updated this revision to Diff 7676.Oct 26 2016, 3:10 PM

Fix comments.

Apparently I also need to try to compile after adding documentation...

graesslin updated this revision to Diff 7686.Oct 27 2016, 6:42 AM

Server implementation changed in a way that one can unset the
focused pointer surface while a gesture is in progress.

In addition update and cancel only perform operations if a
gesture is in progress. This allows KWin to cancel gestures at
any time without having to track whether a gesture is in progress.

sebas added a subscriber: sebas.Nov 7 2016, 12:07 PM

looks good aside from some minor doc polishing

src/client/pointergestures.h
166

s/a/the

226

is *in* progress

sebas accepted this revision.Nov 7 2016, 12:07 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Nov 7 2016, 12:07 PM
graesslin marked 2 inline comments as done.Nov 7 2016, 12:28 PM
This revision was automatically updated to reflect the committed changes.